Draft
Conversation
There was a problem hiding this comment.
Checkov found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚧 DRAFT PR - DO NOT MERGE UNTIL DRAFT STATUS HAS BEEN REMOVED AS WELL AS THIS LINE 🚧
Issue number:
#713
Summary
This PR implements P4 Server Replica Support for the Perforce module, enabling multi-AZ high availability and load distribution. Users can now deploy multiple P4 server replicas (standby, readonly, forwarding, edge) across different availability zones with automated configuration, DNS management, and comprehensive validation.
Changes
Key Changes:
p4_server_replicas_configvariable supporting multiple replica types (standby, readonly, forwarding, edge)p4-serversubmodule with inheritance from primary server configurationFiles Modified:
variables.tf- Added replica configuration variable with validationmain.tf- Added replica module calls with inheritance logics3.tf- S3 bucket and script uploads for replica configurationssm.tf- SSM associations for automated script executionroute53.tf- DNS records for replica subdomainsoutputs.tf- Dynamic outputs for all replica informationmodules/p4-server/iam.tf- Enhanced IAM policies for S3 accessexamples/replica-single-region/- Complete working exampleexamples/replica-cross-region/- Cross-region exampleUser experience
Before:
After:
Results:
standby.perforce.yourdomain.com,ci.perforce.yourdomain.comConnection Strings Available:
Use Cases Enabled:
Cross-Region Support: Infrastructure supports both same-region and cross-region replica deployments with provider aliases and networking validation
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.